Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update duplicate skill model classes check #1415

Merged
merged 1 commit into from
Jun 24, 2020
Merged

update duplicate skill model classes check #1415

merged 1 commit into from
Jun 24, 2020

Conversation

marcofavorito
Copy link
Contributor

Proposed changes

update duplicate skill model classes check: filter out those whose module path starts with 'packages.'

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@marcofavorito
update duplicate skill model classes check
263b88b 
filter out those whose module path starts with 'packages.'
DavidMinarsch
DavidMinarsch approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020 •
edited
Loading

Codecov Report

Merging #1415 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1415      +/-   ##
===========================================
+ Coverage    90.70%   90.75%   +0.04%     
===========================================
  Files          213      213              
  Lines        15230    15214      -16     
===========================================
- Hits         13814    13807       -7     
+ Misses        1416     1407       -9
Flag Coverage Δ
#unittests 90.75% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
aea/skills/base.py 97.05% <ø> (ø)
aea/helpers/exec_timeout.py 100.00% <0.00%> (ø)
aea/helpers/multiple_executor.py 91.89% <0.00%> (+0.08%) ⬆️
aea/connections/stub/connection.py 100.00% <0.00%> (+2.04%) ⬆️
aea/connections/base.py 100.00% <0.00%> (+5.10%) ⬆️
aea/connections/scaffold/connection.py 100.00% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70503af...263b88b. Read the comment docs.

@DavidMinarsch DavidMinarsch merged commit 925bf26 into develop Jun 24, 2020
@DavidMinarsch DavidMinarsch deleted the fix/993 branch June 26, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMinarsch DavidMinarsch DavidMinarsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcofavorito @codecov-commenter @DavidMinarsch